Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

regression: fallback offline department #33009

Merged
merged 8 commits into from
Aug 8, 2024
Merged

regression: fallback offline department #33009

merged 8 commits into from
Aug 8, 2024

Conversation

jessicaschelly
Copy link
Member

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@dionisio-bot dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Aug 7, 2024 •
edited
Loading

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 6.11.0, but it targets 6.12.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 7, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 4e2de1c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jessicaschelly jessicaschelly changed the title add test for fallback offline department test: create tests for fallback offline department Aug 7, 2024
@codecov Codecov
Copy link

codecov bot commented Aug 7, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.98%. Comparing base (5388eef) to head (4e2de1c).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #33009   +/-   ##
========================================
  Coverage    54.98%   54.98%           
========================================
  Files         2596     2596           
  Lines        55966    55966           
  Branches     11585    11585           
========================================
  Hits         30771    30771           
  Misses       22552    22552           
  Partials      2643     2643
Flag Coverage Δ
unit 73.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo self-assigned this Aug 8, 2024
@ggazzo ggazzo force-pushed the test/fallback-offline-department branch from d5be75c to eea32b2 Compare August 8, 2024 14:14
@ggazzo ggazzo changed the title test: create tests for fallback offline department regression: fallback offline department Aug 8, 2024
@ggazzo ggazzo added this to the 6.11 milestone Aug 8, 2024
@ggazzo ggazzo marked this pull request as ready for review August 8, 2024 18:55
@ggazzo ggazzo requested review from a team as code owners August 8, 2024 18:55
@jessicaschelly jessicaschelly added the stat: QA assured Means it has been tested and approved by a company insider label Aug 8, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Aug 8, 2024
@ggazzo ggazzo merged commit b3e6d3f into develop Aug 8, 2024
52 checks passed
@ggazzo ggazzo deleted the test/fallback-offline-department branch August 8, 2024 19:13
ggazzo added a commit that referenced this pull request Aug 8, 2024
@jessicaschelly @ggazzo
regression: fallback offline department (#33009)
69661b3 
Co-authored-by: Guilherme Gazzo <[email protected]>
abhinavkrin pushed a commit that referenced this pull request Oct 25, 2024
@jessicaschelly @ggazzo @abhinavkrin
regression: fallback offline department (#33009)
e2c3f5b 
Co-authored-by: Guilherme Gazzo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggazzo ggazzo ggazzo approved these changes

Assignees

@ggazzo ggazzo

Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Milestone
6.11
Development

Successfully merging this pull request may close these issues.
2 participants
@jessicaschelly @ggazzo